Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating VMs (bsc#1199819) #1758

Merged
merged 13 commits into from
Aug 29, 2024
Merged

Migrating VMs (bsc#1199819) #1758

merged 13 commits into from
Aug 29, 2024

Conversation

tbazant
Copy link
Collaborator

@tbazant tbazant commented Aug 8, 2024

PR creator: Description

Migration section deservs to be a chapter + better explanation of migration typs was added

PR creator: Are there any relevant issues/feature requests?

  • bsc#1199819

PR creator: Which product versions do the changes apply to?

When opening a PR, check all versions of the documentation that your PR applies to.

  • SLE 15/openSUSE Leap 15.x

    • SLE 15 next/openSUSE Leap next (current main, no backport necessary)
    • SLE 15 SP6/openSUSE Leap 15.6
    • SLE 15 SP5/openSUSE Leap 15.5
    • SLE 15 SP4/openSUSE Leap 15.4
    • SLE 15 SP3/openSUSE Leap 15.3
    • SLE 15 SP2/openSUSE Leap 15.2
  • SLE 12

    • SLE 12 SP5

PR reviewer only: Have all backports been applied?

The doc team member merging your PR will take care of backporting to older documents.
When opening a PR, do not set the following check box.

  • all necessary backports are done

@tbazant tbazant self-assigned this Aug 8, 2024
Copy link
Collaborator

@jfehlig jfehlig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tomas! I've sprinkled a few comments, but looks good otherwise.

xml/libvirt_migrating_vms.xml Outdated Show resolved Hide resolved
xml/libvirt_migrating_vms.xml Outdated Show resolved Hide resolved
xml/libvirt_migrating_vms.xml Outdated Show resolved Hide resolved
xml/libvirt_migrating_vms.xml Outdated Show resolved Hide resolved
xml/libvirt_migrating_vms.xml Outdated Show resolved Hide resolved
xml/libvirt_migrating_vms.xml Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@tbazant tbazant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestions accepted

xml/libvirt_migrating_vms.xml Outdated Show resolved Hide resolved
xml/libvirt_migrating_vms.xml Outdated Show resolved Hide resolved
xml/libvirt_migrating_vms.xml Outdated Show resolved Hide resolved
xml/libvirt_migrating_vms.xml Outdated Show resolved Hide resolved
Copy link
Collaborator

@dariavladykina dariavladykina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, please see some suggestions here. Thanks!

xml/libvirt_migrating_vms.xml Outdated Show resolved Hide resolved
xml/libvirt_migrating_vms.xml Outdated Show resolved Hide resolved
xml/libvirt_migrating_vms.xml Outdated Show resolved Hide resolved
xml/libvirt_migrating_vms.xml Outdated Show resolved Hide resolved
xml/libvirt_migrating_vms.xml Outdated Show resolved Hide resolved
xml/libvirt_migrating_vms.xml Outdated Show resolved Hide resolved
xml/libvirt_migrating_vms.xml Outdated Show resolved Hide resolved
xml/libvirt_migrating_vms.xml Outdated Show resolved Hide resolved
xml/libvirt_migrating_vms.xml Outdated Show resolved Hide resolved
xml/libvirt_migrating_vms.xml Outdated Show resolved Hide resolved
Co-authored-by: Daria Vladykina <daria.vladykina@suse.com>
</listitem>
</varlistentry>
<varlistentry>
<term>Offline migration transferring all used storage</term>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<term>Offline migration transferring all used storage</term>
<term>Offline migration transferring all used non-shared storage</term>

Copy link
Collaborator

@jfehlig jfehlig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More comments, sorry. I could probably find something that needs tweaked with each reading of these docs :-)

xml/libvirt_migrating_vms.xml Outdated Show resolved Hide resolved
xml/libvirt_migrating_vms.xml Outdated Show resolved Hide resolved
xml/libvirt_migrating_vms.xml Outdated Show resolved Hide resolved
xml/libvirt_migrating_vms.xml Outdated Show resolved Hide resolved
xml/libvirt_migrating_vms.xml Show resolved Hide resolved
xml/libvirt_migrating_vms.xml Outdated Show resolved Hide resolved
xml/libvirt_migrating_vms.xml Outdated Show resolved Hide resolved
@tbazant tbazant merged commit b0c0848 into main Aug 29, 2024
9 checks passed
tbazant added a commit that referenced this pull request Aug 29, 2024
Co-authored-by: Daria Vladykina <daria.vladykina@suse.com>
tbazant added a commit that referenced this pull request Aug 29, 2024
Co-authored-by: Daria Vladykina <daria.vladykina@suse.com>
@tbazant tbazant deleted the tbazant-migrate-vmd-bsc#1199819 branch August 29, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants